fix: modify deprecated functions #6052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use suggested function from the deprecated function's docs Signed-off-by: machichima <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6052 +/- ##
==========================================
+ Coverage 37.05% 37.08% +0.03%
==========================================
Files 1316 1318 +2
Lines 132247 132284 +37
==========================================
+ Hits 48998 49060 +62
+ Misses 78987 78953 -34
- Partials 4262 4271 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
Some functions are marked as deprecated (see image below), and should be changed to others
What changes were proposed in this pull request?
Name origin import
"github.com/flyteorg/flyte/flyteplugins/go/tasks/pluginmachinery/utils"aspluginsUtilsand add new import suggested in deprecated function docs"github.com/flyteorg/flyte/flytestdlib/utils". Modify code based on those inray.goandray_test.go.How was this patch tested?
Unit tests
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link