Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sub_node_interface field to array node #6018

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Nov 15, 2024

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 37.04%. Comparing base (172e816) to head (39122f5).

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/workflow.pb.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6018      +/-   ##
==========================================
- Coverage   37.04%   37.04%   -0.01%     
==========================================
  Files        1316     1316              
  Lines      132262   132267       +5     
==========================================
- Hits        48998    48997       -1     
- Misses      79002    79008       +6     
  Partials     4262     4262              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (ø)
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.46% <ø> (ø)
unittests-flyteidl 7.23% <0.00%> (-0.01%) ⬇️
unittests-flyteplugins 53.73% <ø> (ø)
unittests-flytepropeller 42.63% <ø> (ø)
unittests-flytestdlib 57.57% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Paul Dittamo <[email protected]>
@eapolinario
Copy link
Contributor

Can we move this out of draft mode, @pvditt ?

@pvditt pvditt changed the title add is_original_sub_node_interface field to array node add sub_node_interface field to array node Nov 19, 2024
@pvditt pvditt marked this pull request as ready for review November 19, 2024 21:37
@pvditt
Copy link
Contributor Author

pvditt commented Nov 19, 2024

@eapolinario yup - was waiting on some consensus on some backward compatibility concerns.

@eapolinario
Copy link
Contributor

@pvditt , can you merge master to get rid of the test docs CI failure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Cold PRs
Development

Successfully merging this pull request may close these issues.

2 participants