Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct stow listing function #6013

Merged

Conversation

bgedik
Copy link
Contributor

@bgedik bgedik commented Nov 14, 2024

Why are the changes needed?

The listing function added for stow container as part of RFC #5598 has a bug, which we hit when doing E2E testing. The Items() stow container function behavior implemented in the listing test mock container differed from the actual behavior. Thus the test was asserting against incorrect behavior.

What changes were proposed in this pull request?

Correct listing function to return full URIs.

How was this patch tested?

Corrected unit test (in repo)
Also tested against minio

Related PRs

#5795

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.96%. Comparing base (f27aff4) to head (aa00023).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6013   +/-   ##
=======================================
  Coverage   36.95%   36.96%           
=======================================
  Files        1310     1312    +2     
  Lines      131464   131516   +52     
=======================================
+ Hits        48587    48614   +27     
- Misses      78656    78674   +18     
- Partials     4221     4228    +7     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.05% <ø> (-0.03%) ⬇️
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.39% <ø> (ø)
unittests-flyteidl 7.05% <ø> (+0.09%) ⬆️
unittests-flyteplugins 53.80% <ø> (-0.03%) ⬇️
unittests-flytepropeller 43.10% <ø> (ø)
unittests-flytestdlib 55.26% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wild-endeavor
wild-endeavor previously approved these changes Nov 14, 2024
@wild-endeavor wild-endeavor merged commit f62c7b6 into flyteorg:master Nov 14, 2024
52 checks passed
wild-endeavor pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants