Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Documentation for Registering Workflows to avoid confusion #5941

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

sumana-2705
Copy link
Contributor

Tracking issue : #5435

Why are the changes needed?

These changes are necessary to enhance the clarity for first-time users, ensuring they understand how to register workflows without confusion.

What changes were proposed in this pull request?

Updated note section to remove "Like pyflyte register" in registering_workflows.md file.

Screenshots

Screenshot 2024-10-30 115429

Check all the applicable boxes

  • All commits are signed-off.

Related PRs

@sumana-2705
Copy link
Contributor Author

Hello @davidmirror-ops

I have changed few lines as mentioned in this issue #5435 by Fabio, Please review these changes

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.84%. Comparing base (553a702) to head (122dc67).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5941      +/-   ##
==========================================
- Coverage   36.84%   36.84%   -0.01%     
==========================================
  Files        1309     1309              
  Lines      130967   130967              
==========================================
- Hits        48259    48252       -7     
- Misses      78524    78531       +7     
  Partials     4184     4184              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.12% <ø> (-0.03%) ⬇️
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.64% <ø> (ø)
unittests-flytepropeller 43.00% <ø> (ø)
unittests-flytestdlib 55.39% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@davidmirror-ops davidmirror-ops merged commit 6168643 into flyteorg:master Oct 30, 2024
50 of 51 checks passed
Copy link

welcome bot commented Oct 30, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants