Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed [Docs] Spot/interruptible docs imply retries come from the user… Closes #3956 #5938

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

ap0calypse8
Copy link
Contributor

@ap0calypse8 ap0calypse8 commented Oct 29, 2024

… retry budget #3956

What changes were proposed in this pull request?

This PR clarifies the documentation regarding retry behavior for interruptible tasks in Flyte. It updates sections to emphasize that retries for spot/interruptible instances utilize the system retry budget rather than the user-specified retry budget. Changes are made in the user guide and related documentation files to ensure accurate guidance for users managing task retries on preemptible compute resources.

Copy link

welcome bot commented Oct 29, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

docs/user_guide/concepts/main_concepts/tasks.rst Outdated Show resolved Hide resolved
@ap0calypse8
Copy link
Contributor Author

@neverett @ppiegaze I’ve worked on the issue and would appreciate it if you could review my changes. I'm waiting for your feedback before we can merge. Thank you!

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.84%. Comparing base (553a702) to head (7f7a5a9).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5938      +/-   ##
==========================================
- Coverage   36.84%   36.84%   -0.01%     
==========================================
  Files        1309     1309              
  Lines      130967   130994      +27     
==========================================
+ Hits        48259    48268       +9     
- Misses      78524    78536      +12     
- Partials     4184     4190       +6     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (-0.04%) ⬇️
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.64% <ø> (ø)
unittests-flytepropeller 43.02% <ø> (+0.01%) ⬆️
unittests-flytestdlib 55.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Anirban Pal <[email protected]>
@ap0calypse8
Copy link
Contributor Author

I am waiting for workflow approval from maintainers @davidmirror-ops . Thanks!

@davidmirror-ops
Copy link
Contributor

Next time you can also install requirements and build locally with make -c html to catch syntax errors

@ap0calypse8
Copy link
Contributor Author

@davidmirror-ops As i have updated the syntax of the docs ....unit test flytectl failing has no relation to my commit.this test failure might be:

A flaky test
An existing issue in the master branch
An environmental issue in CI

help me out please

Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davidmirror-ops davidmirror-ops merged commit a3ef15f into flyteorg:master Oct 31, 2024
51 checks passed
Copy link

welcome bot commented Oct 31, 2024

Congrats on merging your first pull request! 🎉

@ap0calypse8
Copy link
Contributor Author

@davidmirror-ops thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants