Decouple ray submitter, worker, and head resources #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sovietaced
force-pushed
the
issue-5666
branch
2 times, most recently
from
146c464
to
75c0ceb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5933 +/- ##
==========================================
- Coverage 36.95% 36.95% -0.01%
==========================================
Files 1310 1310
Lines 131401 131451 +50
==========================================
+ Hits 48556 48574 +18
- Misses 78631 78656 +25
- Partials 4214 4221 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Oct 29, 2024
Sovietaced
force-pushed
the
issue-5666
branch
from
75c0ceb
to
c9fb595
Compare
Sovietaced
force-pushed
the
issue-5666
branch
2 times, most recently
from
9ee91c1
to
c5185dd
Compare
eapolinario
reviewed
Nov 12, 2024
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
force-pushed
the
issue-5666
branch
from
c5185dd
to
2ab33a1
Compare
This was referenced Nov 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #5666
Why are the changes needed?
If you try to use the Ray plugin for GPU related workloads the submitter pod ends up consuming as many GPUs as the heads/worker nodes.
What changes were proposed in this pull request?
This pull request introduces resources fields in the worker and head node specs. It then uses the task resources for the submitter pod.
How was this patch tested?
Unit tests
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flytekit PR will come
Docs link
TBA