Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-666 Change "Accessing attributes" to "Accessing attributes in workflows" #5886

Conversation

ppiegaze
Copy link
Member

Tracking issue

DOC-666

Why are the changes needed?

Minor clarification suggested by @thomas here: https://unionai.slack.com/archives/C02CMUNT4PQ/p1729211883670849

What changes were proposed in this pull request?

Change in wording. Additional explanation

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.81%. Comparing base (56b6d6d) to head (0637754).
Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5886      +/-   ##
==========================================
+ Coverage   36.71%   36.81%   +0.09%     
==========================================
  Files        1304     1310       +6     
  Lines      130081   131037     +956     
==========================================
+ Hits        47764    48240     +476     
- Misses      78147    78611     +464     
- Partials     4170     4186      +16     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.04% <ø> (-0.38%) ⬇️
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.92% <ø> (+0.03%) ⬆️
unittests-flyteplugins 53.64% <ø> (+0.01%) ⬆️
unittests-flytepropeller 42.90% <ø> (+0.05%) ⬆️
unittests-flytestdlib 55.41% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

neverett
neverett previously approved these changes Oct 22, 2024
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small copyedits, otherwise LGTM

docs/user_guide/data_types_and_io/accessing_attributes.md Outdated Show resolved Hide resolved
@poorvibajpai
Copy link

/assign

@davidmirror-ops davidmirror-ops merged commit 6a740a8 into master Nov 12, 2024
51 checks passed
@davidmirror-ops davidmirror-ops deleted the peeter/doc-666-change-accessing-attributes-to-accessing-attributes-in branch November 12, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants