Add basic SASL and TLS support for Kafka cloud events #5814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #3220
Why are the changes needed?
These changes are needed to use cloud events with kafka brokers with password or certificate auth enabled.
What changes were proposed in this pull request?
This change expands the
KafkaConfig
struct to include some SASL fields for password based auth as well as aTLSConfig
struct for certificate based auth. It then provides a helper function to load these into the Sarama config. Lastly it adds helm support for loading the cloud events config from a secret since password based auth will contain sensitive fields.How was this patch tested?
This was tested on our production Flyte clusters.
Check all the applicable boxes