Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable caching in flyte-core helmchart #5739

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

cpaulik
Copy link
Contributor

@cpaulik cpaulik commented Sep 11, 2024

Why are the changes needed?

Without this caching was actually not enabled when deploying with the flyte-core helm chart

What changes were proposed in this pull request?

Adding storage to the cache.yaml file so that the configuration values for storage.cache.max_size_mbs and storage.cache.target_gc_percet are picked up correctly

How was this patch tested?

I've deployed flyte core without this change and caching was not enabled. After I added

configmap:
  core:
    storage:
      cache:
        max_size_mbs: 5000
        target_gc_percent: 70

caching started working so I assume that adding storage in the cache.yaml would also work.

Copy link

welcome bot commented Sep 11, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@cpaulik cpaulik changed the title Without this caching is actually not enabled Enable caching in flyte-core helmchart Sep 11, 2024
@cpaulik
Copy link
Contributor Author

cpaulik commented Sep 11, 2024

For DCO I'm waiting for our legal department so this might take a bit for the first contribution.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@312910d). Learn more about missing BASE report.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5739   +/-   ##
=========================================
  Coverage          ?   36.29%           
=========================================
  Files             ?     1305           
  Lines             ?   109997           
  Branches          ?        0           
=========================================
  Hits              ?    39927           
  Misses            ?    65914           
  Partials          ?     4156           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (?)
unittests-flyteadmin 55.62% <ø> (?)
unittests-flytecopilot 12.17% <ø> (?)
unittests-flytectl 62.21% <ø> (?)
unittests-flyteidl 7.12% <ø> (?)
unittests-flyteplugins 53.35% <ø> (?)
unittests-flytepropeller 41.88% <ø> (?)
unittests-flytestdlib 55.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpaulik cpaulik force-pushed the fix-caching-flyte-core-helmchart branch from 4b112df to bd85939 Compare September 12, 2024 15:08
@cpaulik
Copy link
Contributor Author

cpaulik commented Sep 12, 2024

DCO should be fixed

pingsutw
pingsutw previously approved these changes Sep 12, 2024
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing it

@davidmirror-ops
Copy link
Contributor

@cpaulik Thank so much! Also to fix the problem detected by generate_helm, you should be able to run make helm in your fork and push the changes

@cpaulik
Copy link
Contributor Author

cpaulik commented Sep 17, 2024

I ran make helm and updated the commit

Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@eapolinario eapolinario enabled auto-merge (squash) September 18, 2024 19:03
@eapolinario eapolinario merged commit 0eaa20e into flyteorg:master Sep 18, 2024
54 of 55 checks passed
Copy link

welcome bot commented Sep 18, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants