Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go version from go.mod files in CI #5736

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eapolinario
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

We currently maintain the go version as part of CI runs by using an input which is passed down to all reusable gh workflows. By relying on the version set on each specific component go.mod file we can simplify version management.

What changes were proposed in this pull request?

Switch to using go-version-file in the actions/setup-go gh action.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.06%. Comparing base (b220c9c) to head (ac3e0d3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5736      +/-   ##
==========================================
- Coverage   37.06%   37.06%   -0.01%     
==========================================
  Files        1316     1316              
  Lines      132178   132178              
==========================================
- Hits        48994    48989       -5     
- Misses      78922    78926       +4     
- Partials     4262     4263       +1     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.08% <ø> (-0.03%) ⬇️
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.46% <ø> (ø)
unittests-flyteidl 7.25% <ø> (ø)
unittests-flyteplugins 53.72% <ø> (ø)
unittests-flytepropeller 42.63% <ø> (ø)
unittests-flytestdlib 57.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@eapolinario eapolinario changed the title [wip] - Use go version from go.mod files in CI Use go version from go.mod files in CI Nov 22, 2024
@eapolinario eapolinario enabled auto-merge (squash) November 22, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant