-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flyteagent] Add Logging for Agent Supported Task Types #5718
Conversation
Signed-off-by: Future-Outlier <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5718 +/- ##
=======================================
Coverage 36.16% 36.17%
=======================================
Files 1303 1303
Lines 109661 109668 +7
=======================================
+ Hits 39664 39671 +7
Misses 65852 65852
Partials 4145 4145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Future-Outlier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. Thanks for improving the log!
* Add Logging for Agent-Supported Task Types Signed-off-by: Future-Outlier <[email protected]> * use make(map[string]struct{}) Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
* Add Logging for Agent-Supported Task Types Signed-off-by: Future-Outlier <[email protected]> * use make(map[string]struct{}) Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
* Add Logging for Agent-Supported Task Types Signed-off-by: Future-Outlier <[email protected]> * use make(map[string]struct{}) Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Tracking issue
#3936
Why are the changes needed?
We want to know whether the propeller received the expected
Supported Task Types
from eachAgent Deployment
and allSupported Task Types
.https://flyte-org.slack.com/archives/C06SYN9QJ5N/p1724970466413009
What changes were proposed in this pull request?
Summary
Add logs to track the
Supported Task Types
for each deployment and across all deployments.Details
Use
map[string]struct{}
to store supported task types because current flytekit will returnSupportedTaskTypes
andsupportedTaskCategories
with same metadata, which will make us get duplicate dataHow was this patch tested?
Screenshots
Check all the applicable boxes