-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable echo plugin by default #5679
Conversation
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5679 +/- ##
==========================================
- Coverage 36.18% 36.18% -0.01%
==========================================
Files 1302 1302
Lines 109614 109614
==========================================
- Hits 39660 39659 -1
- Misses 65809 65810 +1
Partials 4145 4145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we build an image and check it in the configmap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @pingsutw
Should we add echo
plugin type here?
https://github.com/flyteorg/flyte/blob/master/deployment/test/flyte_generated.yaml#L428-L431
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Tracking issue
NA
Why are the changes needed?
flyteorg/flytekit#2654 adds an echo task, which can be used in the conditional workflow. However, it doesn't work out of the box. The platform engineer has to update the propeller config to enable it.
What changes were proposed in this pull request?
Enable it by default.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA