Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failures in generate_helm CI check #5587

Merged

Conversation

eapolinario
Copy link
Contributor

Why are the changes needed?

The generate_helm CI check was not marked as required, so it failed in #5579 but the PR was merged nonetheless.

What changes were proposed in this pull request?

I marked the generate_helm CI check as required and regenerated helm charts via make helm.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.91%. Comparing base (4514860) to head (787f41b).
Report is 116 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5587   +/-   ##
=======================================
  Coverage   35.91%   35.91%           
=======================================
  Files        1301     1301           
  Lines      109403   109403           
=======================================
  Hits        39289    39289           
  Misses      66017    66017           
  Partials     4097     4097           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 53.74% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.28% <ø> (ø)
unittests-flyteidl 7.09% <ø> (ø)
unittests-flyteplugins 53.31% <ø> (ø)
unittests-flytepropeller 41.75% <ø> (ø)
unittests-flytestdlib 55.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 1e54d21 into master Jul 24, 2024
55 checks passed
@eapolinario eapolinario deleted the fix-helm-chart-discrepancies-caused-by-serviceaccounts branch July 24, 2024 15:12
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant