Remove confusing prometheus configuration options in helm charts #5549
+12
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sovietaced
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5549 +/- ##
=======================================
Coverage 60.98% 60.98%
=======================================
Files 796 796
Lines 51647 51647
=======================================
Hits 31498 31498
Misses 17249 17249
Partials 2900 2900
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sovietaced
changed the title
Signed-off-by: Jason Parraga <[email protected]>
pingsutw
approved these changes
Jul 17, 2024
eapolinario
approved these changes
Jul 22, 2024
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
…g#5549) Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We ran into an issue where we lost metrics when we configured propeller's
prof-portto be different than the default value. There's a couple issues here.prof-port, but the prometheus server is always mounted on theprof-port.So this change simplifies the configuration and makes it less fragile in the event the the
prof-portchanges.How was this patch tested?
The rendered helm chart values have no diff.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link