Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] [flyteagent] Add agent-service endpoint settings for flyte-core deployment #5208

Merged
merged 7 commits into from
Apr 10, 2024

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Apr 10, 2024

Tracking issue

#3936

Docs Link

developing agents: https://flyte--5208.org.readthedocs.build/en/5208/flyte_agents/developing_agents.html
testing agents in a local development cluster: https://flyte--5208.org.readthedocs.build/en/5208/flyte_agents/testing_agents_in_a_local_development_cluster.html

Why are the changes needed?

Let users set up agent service when using flyte-core deployment.

You can see the full dialogue here: https://flyte-org.slack.com/archives/CP2HDHKE1/p1712575079971829

What changes were proposed in this pull request?

add more information for users to override config map about agents.

defaultAgent:
    defaultTimeout: 10s
    endpoint: dns:///flyteagent.flyte.svc.cluster.local:8000
    insecure: true
    timeouts:
      CreateTask: 5s
      GetTask: 5s
      DeleteTask: 5s
      ExecuteTaskSync: 10s

How was this patch tested?

flyte-core deployment.

Screenshots

image image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Apr 10, 2024
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier removed the documentation Improvements or additions to documentation label Apr 10, 2024
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title Add agent-service endpoint settings for flyte-core deployment [easy] [flyteagent] Add agent-service endpoint settings for flyte-core deployment Apr 10, 2024
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2024
@pingsutw pingsutw merged commit 1ac8bbe into master Apr 10, 2024
51 checks passed
@pingsutw pingsutw deleted the flyteagent-helm-value-enhancement branch April 10, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants