Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying default cluster pool assignments in admin config #4208

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

katrogan
Copy link
Contributor

Tracking issue

N/A

Describe your changes

Allows specifying cluster pools in helm chart. Change added in flyteadmin here: 07ff730

Tested by setting

clusterpool_config:
  clusterPools:
    clusterPoolAssignments:
      development:
        pool: pool1

in values.yaml and asserting that generated helm chart changes rendered:

+  clusterpool_config.yaml: | 
+    clusterPools:
+      clusterPoolAssignments:
+        development:
+          pool: pool1

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

@katrogan katrogan merged commit ba10ac0 into master Oct 12, 2023
12 checks passed
@katrogan katrogan deleted the cluster-pools branch October 12, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants