Moving from flyteplugins - Implement Spark pod template tolerations #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Andrew Dye <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
8 tasks
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4130 +/- ##
==========================================
+ Coverage 58.98% 59.50% +0.52%
==========================================
Files 619 216 -403
Lines 52804 15938 -36866
==========================================
- Hits 31146 9484 -21662
+ Misses 19174 5479 -13695
+ Partials 2484 975 -1509
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewwdye
force-pushed
the
monorepo-move/flyteplugins/spark-pod-templates
branch
from
1506281
to
2babaab
Compare
Signed-off-by: Andrew Dye <[email protected]>
andrewwdye
force-pushed
the
monorepo-move/flyteplugins/spark-pod-templates
branch
from
2babaab
to
a086d07
Compare
|
Closing in favor of #4183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Populate driver and executor tolerations from optional pod templates. This is an initial step narrowly focused on pod tolerations, to be followed by a more generic solution that handles all pod template functionality.
Type
Are all requirements met?
Complete description
This change builds on optional Spark pod template changes added in flyteorg/flyteidl#450. For now appends tolerations from the driver and executor pod templates, if any, to the defaults used to build the SparkApplicationSpec. A follow up PR will refactor the Spark plugin and pod_helper.go to reuse ToK8sPodSpec in order to consume other aspect of pod templates, as is done for other plugins.
Tracking Issue
#4105