Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #3070
Describe your changes
Check all the applicable boxes
Screenshots
I tested the latest flyteadmin
v1.1.129
usingflyte-core
chart running on GKE v1.26 with these configs:And observe the correct notifications config passed to
flyte-admin-base-config
configmapFlyteadmin is able to run successfully.
Note to reviewers
Note: I have not tested this on AWS as I do not have easy access (if someone could that would be great!)