Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix helm notifications config #4055

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

dyu-bot
Copy link
Contributor

@dyu-bot dyu-bot commented Sep 20, 2023

Tracking issue

Closes #3070

Describe your changes

  • Remove deprecated region field in NotificationsConfig
  • Sets cloud provider config depending on which provider type is specified. This is needed in order for cloud-based notifications to work (guessing it's blocked now for both GCP and AWS). See this issue.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

I tested the latest flyteadmin v1.1.129 using flyte-core chart running on GKE v1.26 with these configs:

  workflow_notifications:
    enabled: true
    config:
      notifications:
        type: gcp
        gcp:
          projectId: xxx
        publisher:
          topicName: "xxx"
        processor:
          queueName: "xxx"
        emailer:
          emailServerConfig:
            serviceName: sendgrid
            apiKeyEnvVar: xxx
          subject: "Notice: Execution \"{{ workflow.name }}\" has {{ phase }} in \"{{ domain }}\"."
          sender:  "xxx"
          body: >
             Execution \"{{ workflow.name }} [{{ name }}]\" has {{ phase }} in \"{{ domain }}\". View details at
             <a href=\https://xxx.com/console/projects/{{ project }}/domains/{{ domain }}/executions/{{ name }}>
             https://xxx.com/console/projects/{{ project }}/domains/{{ domain }}/executions/{{ name }}</a>. {{ error }}

And observe the correct notifications config passed to flyte-admin-base-config configmap

Flyteadmin is able to run successfully.

Note to reviewers

Note: I have not tested this on AWS as I do not have easy access (if someone could that would be great!)

@welcome
Copy link

welcome bot commented Sep 20, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@dyu-bot dyu-bot force-pushed the dyu/helm-notifications-config-fix branch from 16871a5 to 9ba5f64 Compare September 20, 2023 08:35
@pingsutw pingsutw merged commit be7c789 into flyteorg:master Sep 20, 2023
11 checks passed
@welcome
Copy link

welcome bot commented Sep 20, 2023

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants