Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set reasonable defaults and unconstrained limits for flyte-sandbox #4038

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Set reasonable defaults and unconstrained limits for flyte-sandbox #4038

merged 1 commit into from
Sep 15, 2023

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Sep 15, 2023 •
edited by wild-endeavor
Loading

ran a job with a request of 3c/4Gi

    resources:
      limits:
        cpu: "3"
        memory: 4Gi
      requests:
        cpu: "3"
        memory: 4Gi

if no requests specified, looks like this:

    resources:
      limits:
        cpu: 500m
        memory: 1Gi
      requests:
        cpu: 500m
        memory: 1Gi

@jeevb jeevb merged commit ad57484 into master Sep 15, 2023
15 checks passed
@jeevb jeevb deleted the jeev/flyte-binary-task-resource-defaults-limits branch September 15, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wild-endeavor wild-endeavor wild-endeavor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeevb @wild-endeavor