Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment documentation for Bigquery agent #4034

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Deployment documentation for Bigquery agent #4034

merged 4 commits into from
Sep 25, 2023

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Sep 14, 2023

Tracking issue

#3936

Preview: https://flyte--4034.org.readthedocs.build/en/4034/deployment/index.html

Describe your changes

  • Add a new section for the Flyte agent in the deployment guide.
  • Deployment documentation for Bigquery agents

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

image

Note to reviewers

NA

@pingsutw
Copy link
Member Author

@samhita-alla I plan to add a new section for agents. Putting the agent and plugin doc together makes people confused. wdyt?

@pingsutw pingsutw mentioned this pull request Sep 15, 2023
11 tasks
@kumare3
Copy link
Contributor

kumare3 commented Sep 16, 2023

@pingsutw i agree we actually have a new docs layout

Copy link
Contributor

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add deployment/agents/index entry on the TOC here: https://github.com/flyteorg/flyte/blob/master/rsts/index.rst?plain=1#L33

Signed-off-by: Kevin Su <[email protected]>
cosmicBboy
cosmicBboy previously approved these changes Sep 25, 2023
@@ -31,6 +31,15 @@ plugins, authentication, performance tuning, and maintaining Flyte as a producti

---

.. link-button:: deployment-agent-setup
:type: ref
:text: 🔥 Agent Setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 🔥 -> 🤖

😃

Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw merged commit 86e3a2c into master Sep 25, 2023
16 checks passed
@pingsutw pingsutw deleted the bq-agent branch September 25, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants