Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flyte-core helm charts for multi cluster configuration #3993

Merged
merged 5 commits into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/flyte-binary/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,3 +190,4 @@ Chart for basic single Flyte executable deployment
| serviceAccount.imagePullSecrets | list | `[]` | |
| serviceAccount.labels | object | `{}` | |
| serviceAccount.name | string | `""` | |

2 changes: 1 addition & 1 deletion charts/flyte-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -277,4 +277,4 @@ helm install gateway bitnami/contour -n flyte
| webhook.serviceAccount.create | bool | `true` | Should a service account be created for the webhook |
| webhook.serviceAccount.imagePullSecrets | list | `[]` | ImagePullSecrets to automatically assign to the service account |
| workflow_notifications | object | `{"config":{},"enabled":false}` | **Optional Component** Workflow notifications module is an optional dependency. Flyte uses cloud native pub-sub systems to notify users of various events in their workflows |
| workflow_scheduler | object | `{"config":{},"enabled":false,"type":""}` | **Optional Component** Flyte uses a cloud hosted Cron scheduler to run workflows on a schedule. The following module is optional. Without, this module, you will not have scheduled launchplans / workflows. Docs: https://docs.flyte.org/en/latest/howto/enable_and_use_schedules.html#setting-up-scheduled-workflows |
| workflow_scheduler | object | `{"config":{},"enabled":false,"type":""}` | **Optional Component** Flyte uses a cloud hosted Cron scheduler to run workflows on a schedule. The following module is optional. Without, this module, you will not have scheduled launchplans / workflows. Docs: https://docs.flyte.org/en/latest/howto/enable_and_use_schedules.html#setting-up-scheduled-workflows |
5 changes: 5 additions & 0 deletions charts/flyte-core/templates/admin/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@ spec:
name: clusters-config-volume
- mountPath: /etc/secrets/
name: admin-secrets
{{- if gt (len .Values.configmap.clusters.labelClusterMap) 0 }}
{{- with .Values.flyteadmin.additionalVolumeMounts -}}
{{ tpl (toYaml .) $ | nindent 10 }}
{{- end }}
{{- end }}
{{- end }}
- name: generate-secrets
image: "{{ .Values.flyteadmin.image.repository }}:{{ .Values.flyteadmin.image.tag }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ spec:
name: config-volume
{{- if gt (len .Values.configmap.clusters.labelClusterMap) 0 }}
- mountPath: /var/run/credentials
name: flyte-admin-secrets
name: cluster-secrets
{{- end }}
serviceAccountName: {{ .Values.cluster_resource_manager.service_account_name }}
{{- if .Values.cluster_resource_manager.resources }}
Expand All @@ -55,9 +55,9 @@ spec:
name: flyte-clusterresourcesync-config
name: config-volume
{{- if gt (len .Values.configmap.clusters.labelClusterMap) 0 }}
- name: flyte-admin-secrets
- name: cluster-secrets
secret:
secretName: flyte-admin-secrets
secretName: cluster-credentials
{{- end }}
{{- if .Values.cluster_resource_manager.config.cluster_resources.standaloneDeployment }}
- name: auth
Expand Down
2 changes: 1 addition & 1 deletion charts/flyte-deps/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,4 +119,4 @@ helm upgrade -f values.yaml flyte .
| sparkoperator | object | `{"enabled":false}` | Optional: Spark Plugin using the Spark Operator |
| sparkoperator.enabled | bool | `false` | - enable or disable Sparkoperator deployment installation |
| webhook.enabled | bool | `true` | |
| webhook.service | object | `{"annotations":{"projectcontour.io/upstream-protocol.h2c":"grpc"},"type":"ClusterIP"}` | Service settings for the webhook |
| webhook.service | object | `{"annotations":{"projectcontour.io/upstream-protocol.h2c":"grpc"},"type":"ClusterIP"}` | Service settings for the webhook |
1 change: 1 addition & 0 deletions charts/flyte-sandbox/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,4 @@ A Helm chart for the Flyte local sandbox
| sandbox.proxy.image.pullPolicy | string | `"Never"` | |
| sandbox.proxy.image.repository | string | `"envoyproxy/envoy"` | |
| sandbox.proxy.image.tag | string | `"sandbox"` | |

2 changes: 1 addition & 1 deletion charts/flyte/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -268,4 +268,4 @@ helm upgrade -f values-sandbox.yaml flyte .
| redoc.service | object | `{"type":"ClusterIP"}` | Service settings for Minio |
| redoc.tolerations | list | `[]` | tolerations for Minio deployment |
| sparkoperator | object | `{"enabled":false}` | Optional: Spark Plugin using the Spark Operator |
| sparkoperator.enabled | bool | `false` | - enable or disable Sparkoperator deployment installation |
| sparkoperator.enabled | bool | `false` | - enable or disable Sparkoperator deployment installation |
Loading