Skip to content

Commit

Permalink
Add option to install CRD as a part of chart install in flyte-binary
Browse files Browse the repository at this point in the history
Signed-off-by: marrrcin <[email protected]>
  • Loading branch information
marrrcin committed Nov 6, 2024
1 parent 96c467e commit 66f839c
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/flyte-binary/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ data:
show-source: true
level: {{ default 1 .Values.configuration.logging.level }}
propeller:
create-flyteworkflow-crd: true
create-flyteworkflow-crd: {{ .Values.configuration.propeller.createCrd }}
webhook:
certDir: /var/run/flyte/certs
localCert: true
Expand Down
32 changes: 32 additions & 0 deletions charts/flyte-binary/templates/crds/flyteworkflow.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{{- if .Values.crds.create }}
{{- if $.Capabilities.APIVersions.Has "apiextensions.k8s.io/v1/CustomResourceDefinition" }}
apiVersion: apiextensions.k8s.io/v1
{{- else }}
apiVersion: apiextensions.k8s.io/v1beta1
{{- end }}
kind: CustomResourceDefinition
metadata:
name: flyteworkflows.flyte.lyft.com
spec:
group: flyte.lyft.com
names:
kind: FlyteWorkflow
plural: flyteworkflows
shortNames:
- fly
singular: flyteworkflow
scope: Namespaced
{{- if $.Capabilities.APIVersions.Has "apiextensions.k8s.io/v1/CustomResourceDefinition" }}
versions:
- name: v1alpha1
served: true
storage: true
schema:
openAPIV3Schema:
type: object
x-kubernetes-preserve-unknown-fields: true
properties:
{{- else }}
version: v1alpha1
{{- end }}
{{- end }}
7 changes: 7 additions & 0 deletions charts/flyte-binary/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@ configuration:
timeouts:
GetTask: 10s
defaultTimeout: 10s
# propeller Specify configuration for Flyte Propeller
propeller:
createCrd: true
# externalConfigMap Specify an existing, external ConfigMap to use as configuration for Flyte
# If set, no Flyte configuration will be generated by this chart
externalConfigMap: ""
Expand Down Expand Up @@ -375,6 +378,10 @@ rbac:
# extraRules Add additional rules to the ClusterRole
extraRules: []

crds:
# create Create CustomResourceDefinition resources during installation
create: false

# serviceAccount Configure Flyte ServiceAccount
serviceAccount:
# create Create ServiceAccount for Flyte
Expand Down

0 comments on commit 66f839c

Please sign in to comment.