fix(helm): skip redoc when redoc.enabled is set to false

The flyte chart includes four templates: minio, postgres, redis, and redoc. A property following the pattern `<template_name>.enabled` does exist in the `values.yaml` file. It is used to enabled/disable the template. Setting `redoc.enabled` to `false` does not disable the `redoc` deployment and service. This changeset fixes that problem by following the same approach with the other templates: wrapping the resoruces under the `templates/redoc` with an `if` statetement evaluating `Values.redoc.enabled`. closes 4006 Signed-off-by: cmontemuino <[email protected]>
flyteorg · Sep 4, 2023 · 2ff8a7d · 2ff8a7d
1 parent 44f5f42
commit 2ff8a7d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/charts/flyte/templates/redoc/deployment.yaml b/charts/flyte/templates/redoc/deployment.yaml
@@ -1,3 +1,4 @@
+{{- if .Values.redoc.enabled }}
 apiVersion: apps/v1
 kind: Deployment
 metadata:
@@ -42,4 +43,5 @@ spec:
       {{- with .Values.redoc.tolerations }}
       tolerations: {{ tpl (toYaml .) $ | nindent 8 }}
       {{- end }}
+{{- end }}
 
diff --git a/charts/flyte/templates/redoc/service.yaml b/charts/flyte/templates/redoc/service.yaml
@@ -1,3 +1,4 @@
+{{- if .Values.redoc.enabled }}
 apiVersion: v1
 kind: Service
 metadata:
@@ -17,3 +18,5 @@ spec:
       port: 87
       targetPort: 8087
   selector: {{ include "redoc.selectorLabels" . | nindent 4 }}
+{{- end }}
+