Added decryption of Kustomize patches and refactor SOPS tests #1286
+346
−287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanprodan tagging you because you have reviewed #1283 for me 😅 |
stefanprodan
added
area/sops
vlasov-y
force-pushed
the
main
branch
2 times, most recently
from
8163ee2
to
96206e3
Compare
stefanprodan
reviewed
Dec 3, 2024
docs/spec/v1/kustomizations.md
Outdated
| @@ -788,6 +790,86 @@ data: | |||
| sops.vault-token: <BASE64> | |||
| ``` | |||
|
|
|||
| #### Important case: SOPS decryption encrypted_regex conflict | |||
There was a problem hiding this comment.
This example could be in the docs guide here: https://fluxcd.io/flux/guides/mozilla-sops/
For the API docs, I think we just need a phrase with just the solution from above.
There was a problem hiding this comment.
Added same text here fluxcd/website#2107
There was a problem hiding this comment.
Great! You can remove now this section and tidy up your commits, then it's good for merge.
There was a problem hiding this comment.
Done. I have squashed all my commits into one.
Cleaned SOPS tests. Signed-off-by: Yuriy <[email protected]>
stefanprodan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ✋
In addition to the previous PR, I've added decryption for the resource and patch files before the build process. I also found the test data for SOPS to be quite messy, so I restructured it entirely and streamlined the controller test code.
Followup: #1283