-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Cannot clone a disposed image #47
base: master
Are you sure you want to change the base?
Conversation
@Solido I would appreciate if you look into this for a minute. |
Kindly merge this please |
this is a severe issue please check this |
@YDA93 I tried your fork and I am still getting the same error. Do you know if there's another way that the same error can appear, or do you know if there are still issues with your fix? |
Hi @andrewwakeling , You can replicate the issue following the steps:
I think this error happens when you clear images from memory while there still images displaying in other screens. I stopped trying to fix this since most of it is none fatal errors. I use extended image library to display images. |
Its possible your error is coming from a different source. See Baseflow/flutter_cached_network_image#746 @YDA93 how did you find out it was coming from this package or more specifically that function that is causing the issue? Because from my error logs I couldn't figure our where its coming from. Edit: Found this flutter/flutter#110129. Issue is fixed but not yet in stable (3.3.4). Fix is in master |
As far as I remember I didn't have this error until i started using this package. I will do some re-tests today and will confirm if the issue comes from this package. |
When I temporarily disable/remove blurhashes from my app, I'm no longer seeing the errors. I can't say with 100% certainty that the fault comes from the blurhash library, but it does seem like the most likely culprit at this point. |
I think we need to test with flutter 3.4.0 at this point to find out the real culprit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, I think this would be helps a lot.
I tried this alternative yesterday and today, but I still have the problem. In my case, I have a widget tree that uses So far, I haven't been able to fit into a fork I've made. Even though it's relatively "simple code", it seems to have a pretty big flow. |
TIL that |
I tried this again and this pr not fix the |
This issue occurs when i use the hash widget on top of cachedNetworkImage widget in a stack. |
@aarjan it also happens at this moment:
|
Same problem here! |
Same problem! Any solution? |
Use Before: After: |
Because Image widget in buildBlurHashBackground does not have errorBuilder, its causing the framework to throw errors as per issues:
Since buildBlurHashBackground is widget function instead of stateless widget this made it even harder to trace where the error is coming from.
Which was pointing to Flutter image widget only, which I think it should include buildBlurHashBackground too.
Please Refer to:
Stackoverflow
Flutter issue 19269
If you look at flutter image widget at image.dart line 1141:
Long story short:
Your code does not produce this error, our code does. Your code only does not enable us to handle it.
Kindly merge this.
Thanks,