Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove js_util #53

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

remove js_util #53

wants to merge 12 commits into from

Conversation

jezell
Copy link

@jezell jezell commented Sep 20, 2024

Fixes #48

@jezell
Copy link
Author

jezell commented Sep 20, 2024

Note that platform_detect is still a blocker on wasm builds, but that's the last one after this.

@jezell jezell marked this pull request as draft September 20, 2024 23:07
@jezell jezell marked this pull request as ready for review September 21, 2024 03:24
@theniceboy
Copy link

Incorrect type casting at https://github.com/jezell/dart-webrtc/blob/a6a18675e48fc7d6b89aa798a18283add17a6b60/lib/src/rtc_rtp_transceiver_impl.dart#L116

Should be

_jsTransceiver.setCodecPreferences(codecs
    .map((e) => e.toMap().jsify())
    .toList()
    .toJS as JSArray<web.RTCRtpCodec>);

@cloudwebrtc
Copy link
Member

looks good to me. e2ee compiles fine, but runs with an error that I'm still trying to fix it.

image

@jezell
Copy link
Author

jezell commented Dec 17, 2024

@cloudwebrtc

Screenshot 2024-12-17 at 12 42 00 AM

Maybe this that I just pushed will fix?

@cloudwebrtc
Copy link
Member

I get another error, it seems that the web package can't run correctly under the web worker

image

when I try to print the web.window.crypto object

TypeError: null: type 'JSNull' is not a subtype of type 'JSObject'
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove package js_util
4 participants