Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic parameters and maps #498

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

victortive
Copy link
Contributor

Fixes #497

@victortive
Copy link
Contributor Author

victortive commented Nov 5, 2024

@cloudwebrtc What are your thoughts on the effort on this and if you are willing to consider it?

All the types are already defined in JsSip for example https://github.com/versatica/JsSIP/blob/master/lib/RTCSession.d.ts

@mikaelwills
Copy link
Collaborator

@victortive Yea i like this, recently when working with this package all the maps and whats being passed in where has been hell.
In the above you've just done terminate?
I feel like its gonna be a long road converting all maps throughout the package

@victortive
Copy link
Contributor Author

@victortive Yea i like this, recently when working with this package all the maps and whats being passed in where has been hell.

In the above you've just done terminate?

I feel like its gonna be a long road converting all maps throughout the package

I just did terminate options, but the main problem is the webrtc library also relies on maps. Both need to be updated

@mikaelwills
Copy link
Collaborator

mikaelwills commented Dec 18, 2024

@victortive Yea i like this, recently when working with this package all the maps and whats being passed in where has been hell.
In the above you've just done terminate?
I feel like its gonna be a long road converting all maps throughout the package

I just did terminate options, but the main problem is the webrtc library also relies on maps. Both need to be updated

@victortive Hmm ohk, well ive just been made a maintaner so im like sweet lets get this package alive and going with updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use more descriptive types instead of dynamic maps.
3 participants