Add Tizen 8.0 bindings #31
Conversation
JSUYA
force-pushed
the
tizen_8
branch
3 times, most recently
from
fcd4645 to
b022328
Compare
|
|
JSUYA
force-pushed
the
tizen_8
branch
2 times, most recently
from
fa298c6 to
3ce1b9e
Compare
| time_t)>>('notification_set_time_to_text'); | ||
| ffi | ||
| .NativeFunction<ffi.Int Function(notification_h, ffi.Int32, time_t)>>( | ||
| 'notification_set_time_to_text'); |
There was a problem hiding this comment.
Are these only formatting changes?
There was a problem hiding this comment.
The format has changed. In my view, there doesn't seem to be any API change.
There was a problem hiding this comment.
We didn't update the ffigen version. What made the changes?
→ ffigen 7.2.10 added parameter names for function pointer arguments.
7.2.10 #
Generate parameter names in function pointer fields and typedefs.
You can update the dev_dependency in pubspec.yaml to the version installed on your machine if you want to be clear.
There was a problem hiding this comment.
Thank you for your review.
I updated ffigen version to latest(11.0.0). And I reverted the ffigen.yaml(4.0 ~ 7.0) changes.
+) I updated the version of the tizen_interop_callbacks package to 0.1.1.
please let me know if there's more to add.
There was a problem hiding this comment.
Tip: Please check out the changelog and README of the ffigen package for newly added, potentially useful configuration options and other features when updating the ffigen version.
There was a problem hiding this comment.
As far as I know, the minimum version we need from ffigen is 8.0.0-dev.0.
( 8.0.0-dev.0 : Adds final class modifier to generated sub types Struct, Union and Opaque...)
If we use ffigen 8.0.0, we need to adjust file package version, but file package applies the fixes made from dart 3.0 in 7.0.0.
Therefore, in order to satisfy the version, ffigen version should be 11.0.0.
The rootstrap path in tizen 8.0 has changed.
API reference: https://docs.tizen.org/application/native/api/common/8.0/
[Updated headers in 8.0]
nntrainer/nntrainer.h
nnstreamer/ml-api-service.h
media/mv_common.h
media/webrtc.h
media/sound_manager.h
media/player.h
media/camera.h
tts.h
rpc-port/rpc-port-parcel.h
stt.h
appfw/app_common.h
appfw/app_control.h
appfw/app.h
web/download.h
network/net_connection.h
network/bluetooth.h
network/wifi-manager.h
peripheral_io.h