Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): integrate each test #10

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix(test): integrate each test #10

merged 1 commit into from
Nov 20, 2023

Conversation

hs0225
Copy link
Contributor

@hs0225 hs0225 commented Nov 3, 2023

Signed-off-by: Hosung Kim [email protected]

@hs0225 hs0225 marked this pull request as draft November 3, 2023 01:55
@hs0225 hs0225 force-pushed the test branch 9 times, most recently from 38ba29f to 411d1da Compare November 8, 2023 05:11
@hs0225 hs0225 marked this pull request as ready for review November 8, 2023 05:28
@hs0225
Copy link
Contributor Author

hs0225 commented Nov 8, 2023

Base on #13

JSUYA
JSUYA reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the example directory? In flutterfire, tests is the app path.
https://github.com/firebase/flutterfire/tree/master/tests

packages/tests/example/test/widget_test.dart Outdated
@@ -0,0 +1,30 @@
// This is a basic Flutter widget test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test file looks to be unused file. You can delete it after check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this file.

packages/tests/pubspec.yaml Show resolved Hide resolved
@hs0225
Copy link
Contributor Author

hs0225 commented Nov 17, 2023

@JSUYA Yes, our test utility is implemented based on the example folder.

@JSUYA
Copy link
Member

JSUYA commented Nov 17, 2023 •
edited
Loading

@JSUYA Yes, our test utility is implemented based on the example folder.

I mean, the directory is duplicated.
flutterfiire -> {root}/tests/integration_test/{each package's test}/.dart
our flutterfiire -> {root}/packages/tests/example/integration_test/{each package's test}/.dart
There is no need for example directory.

+) How about moving tests directory to repo root path?

@hs0225 hs0225 merged commit 8ba9680 into main Nov 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSUYA JSUYA JSUYA approved these changes

@daeyeon daeyeon daeyeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hs0225 @JSUYA @daeyeon