Apply review comments

Signed-off-by: Hosung Kim [email protected]
flutter-tizen · Sep 6, 2023 · 9513632 · 9513632
1 parent 4b9616a
commit 9513632
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 17 deletions.
diff --git a/packages/firebase_storage/README.md b/packages/firebase_storage/README.md
@@ -1,21 +1,9 @@
 # firebase_storage_tizen
 
-A new Flutter plugin project.
+The [Firebase Storage for Flutter](https://pub.dev/packages/firebase_storage) implementation for Tizen.
 
-## Getting Started
+It offers experimental features for using Firebase on Flutter for Tizen. It works by wrapping cross-compiled libraries that are based on the [Firebase C++ SDK](https://github.com/firebase/firebase-cpp-sdk) for Linux.
 
-This project is a starting point for a Flutter
-[plug-in package](https://flutter.dev/developing-packages/),
-a specialized package that includes platform-specific implementation code for
-Android and/or iOS.
-
-For help getting started with Flutter development, view the
-[online documentation](https://flutter.dev/docs), which offers tutorials,
-samples, guidance on mobile development, and a full API reference.
-
-The plugin project was generated without specifying the `--platforms` flag, no platforms are currently supported.
-To add platforms, run `flutter create -t plugin --platforms <platforms> .` in this directory.
-You can also find a detailed instruction on how to add platforms in the `pubspec.yaml` at https://flutter.dev/docs/development/packages-and-plugins/developing-packages#plugin-platforms.
 
 # Usage
 

diff --git a/packages/firebase_storage/example/.gitignore b/packages/firebase_storage/example/.gitignore
@@ -20,6 +20,7 @@ migrate_working_dir/
 .vscode/
 
 # Flutter/Dart/Pub related
+/pubspec.lock
 **/doc/api/
 **/ios/Flutter/.last_build_id
 .dart_tool/

diff --git a/packages/firebase_storage/example/integration_test/extratest_e2e.dart b/packages/firebase_storage/example/integration_test/extratest_e2e.dart
@@ -10,8 +10,7 @@ import 'package:flutter_test/flutter_test.dart';
 
 import './test_utils.dart';
 
-const String kOkString = 'ok';
-final List<int> okStringList = utf8.encode(kOkString);
+const String kOkString = 'kOk';
 
 void setupExtraTests() {
   group('$Reference', () {

diff --git a/packages/firebase_storage/tizen/src/firebase_storage_task.h b/packages/firebase_storage/tizen/src/firebase_storage_task.h
@@ -15,7 +15,6 @@
 #include "flutter_types.hpp"
 
 class StorageTask;
-class StoragePutBytesTask;
 
 class StorageTaskHandler {
  public:

diff --git a/packages/firebase_storage/tizen/src/flutter_types.hpp b/packages/firebase_storage/tizen/src/flutter_types.hpp
@@ -8,6 +8,7 @@
 #include <flutter/encodable_value.h>
 #include <flutter/method_channel.h>
 #include <flutter/method_result.h>
+
 #include <optional>
 #include <cassert>