Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] If there is no action, return immediately #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JSUYA
Copy link
Member

@JSUYA JSUYA commented Dec 4, 2024

The index of DoAction is the number of the action that can be called.
If there is no action that can be called in atk, the index is passed as -1.
Currently, our AXPlatformNode only supports default actions, so we need to distinguish between -1 and numbers greater than 0.
In Tizen, the DoActionName function in atk causes this problem.
Since at-spi2-atk in tizen is not under our management scope, we temporarily return immediately when it is -1 to prevent unnecessary error messages.

error message

[E] ** (Runner.dll:10005): CRITICAL **: 20:27:38.451: gboolean ui::(anonymous namespace)::atk_action::DoAction(AtkAction *, gint): assertion '!index' failed
[E] [0]: /usr/lib/libglog-runtime-env.so+0x78a (g_log_default_handler+0xb9) [0xb618578a]
[E] [1]: /lib/libglib-2.0.so.0+0x5053e (g_logv+0x149) [0xb5a6053e]
[E] [2]: /lib/libglib-2.0.so.0+0x50686 (g_log+0x25) [0xb5a60686]
[3]: /lib/libglib-2.0.so.0+0x50832 (g_return_if_fail_warning+0x11) [0xb5a60832]

The index of DoAction is the number of the action that can be called.
If there is no action that can be called in atk, the index is passed as -1.
Currently, our AXPlatformNode only supports default actions,
so we need to distinguish between -1 and numbers greater than 0.
In Tizen, the DoActionName function in atk causes this problem.
Since at-spi2-atk in tizen is not under our management scope,
we temporarily return immediately when it is -1 to prevent unnecessary error messages.
@JSUYA
Copy link
Member Author

JSUYA commented Dec 4, 2024

#8

@JSUYA JSUYA changed the title [a11y] If there is no action, return immediately. [a11y] If there is no action, return immediately Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant