Call dup not to overwrite original value

Signed-off-by: Yuta Iwama <[email protected]>
fluent · Jan 27, 2020 · 6d53664 · 6d53664
1 parent 38f80c5
commit 6d53664
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/fluent/config/section.rb b/lib/fluent/config/section.rb
@@ -58,6 +58,10 @@ def to_h
         @params
       end
 
+      def dup
+        Section.new(@params.dup, @corresponding_config_element.dup)
+      end
+
       def +(other)
         Section.new(self.to_h.merge(other.to_h))
       end

diff --git a/lib/fluent/plugin_helper/http_server.rb b/lib/fluent/plugin_helper/http_server.rb
@@ -115,7 +115,7 @@ def stop
       private
 
       def _http_server_overwrite_config(config, opts)
-        conf = config
+        conf = config.dup
         Fluent::PluginHelper::Server::SERVER_TRANSPORT_PARAMS.map(&:to_s).each do |param|
           if opts.key?(param)
             conf[param] = opts[param]

diff --git a/test/config/test_section.rb b/test/config/test_section.rb
@@ -40,8 +40,6 @@ class TestSection < ::Test::Unit::TestCase
             assert_equal("email", s1.send)
             assert_equal("normal", s1.klass)
             assert_equal(5, s1.keys)
-
-            assert_raise(NoMethodError) { s1.dup }
           end
 
           test 'creates object which contains specified hash object itself, including fields with at prefix' do
-Original file line number
+Diff line change
@@ Expand Up / @@ -58,6 +58,10 @@ def to_h @@
             @params
           end
+          def dup
+            Section.new(@params.dup, @corresponding_config_element.dup)
+          end
           def +(other)
             Section.new(self.to_h.merge(other.to_h))
           end
@@ Expand Down @@