auto plugin install: disable unless auto #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daipom
force-pushed
the
disable-auto-plugin-install-unless-auto
branch
from
964eb2a to
664ed6b
Compare
daipom
force-pushed
the
feature-nodowntime
branch
from
2ee719f to
e5a6e5a
Compare
daipom
force-pushed
the
disable-auto-plugin-install-unless-auto
branch
from
664ed6b to
2605fce
Compare
This allows users to manually manage plugins by setting FLUENT_PACKAGE_SERVICE_RESTART to manual. For example, there will be cases where a user wants to use a particular plugin version. Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
force-pushed
the
disable-auto-plugin-install-unless-auto
branch
from
2605fce to
bfcc5ee
Compare
|
Rebased. |
daipom
commented
Dec 9, 2024
| @@ -188,8 +188,12 @@ else | |||
| fi | |||
| fi | |||
| if [ $1 -eq 2 ]; then | |||
| # collect installed gems during upgrading | |||
| /usr/sbin/fluent-gem list '^fluent-plugin-' --no-versions --no-verbose > %{local_base_plugins} | |||
| . %{_sysconfdir}/sysconfig/@SERVICE_NAME@ | |||
There was a problem hiding this comment.
I think this can fail when updating from v4.
For some reason, the current test is successful.
I will check these concerns together last.
daipom
added a commit
to daipom/fluent-package-builder
that referenced
this pull request
Dec 10, 2024
This allows users to manually manage plugins by setting FLUENT_PACKAGE_SERVICE_RESTART to manual. For example, there will be cases where a user wants to use a particular plugin version. Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
added a commit
to daipom/fluent-package-builder
that referenced
this pull request
Dec 10, 2024
This allows users to manually manage plugins by setting FLUENT_PACKAGE_SERVICE_RESTART to manual. For example, there will be cases where a user wants to use a particular plugin version. Signed-off-by: Daijiro Fukuda <[email protected]>
kenhys
pushed a commit
that referenced
this pull request
Dec 11, 2024
This allows users to manually manage plugins by setting FLUENT_PACKAGE_SERVICE_RESTART to manual. For example, there will be cases where a user wants to use a particular plugin version. Signed-off-by: Daijiro Fukuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to manually manage plugins by setting FLUENT_PACKAGE_SERVICE_RESTART to manual.
For example, there will be cases where a user wants to use a particular plugin version.