Improve test script #653
Merged
Improve test script #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kenhys
commented
Jul 1, 2024
•
kenhys
commented
- set noninteractive not to block
- do not set UID explicitly on ubuntu
- switch to baseurl (only for testing with local container)
kenhys
force-pushed
the
improve-test-script
branch
2 times, most recently
from
cd81df8 to
a443699
Compare
|
#654 should be merged in advance. |
|
I think we need #655 to make this test succeed. |
kenhys
force-pushed
the
improve-test-script
branch
from
a443699 to
7991bbb
Compare
|
As #654 was merged, rebased it. |
daipom
approved these changes
Jul 4, 2024
It is better not to be blocked with tzdata configuration. Signed-off-by: Kentaro Hayashi <[email protected]>
Since ubuntu:noble, ID=1000 ubuntu user is created. There is not a so many merit from specifying uid currently, so just drop it. Signed-off-by: Kentaro Hayashi <[email protected]>
As CentOS 7 reaches EOL, so it is expected that mirrorlist will be broken gradually, so set baseurl explicitly to improve network connectivity. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
force-pushed
the
improve-test-script
branch
from
7991bbb to
b160a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.