Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update target ruby version to 3.2.4 #645

Merged
merged 1 commit into from
Jun 19, 2024
Merged

update target ruby version to 3.2.4 #645

merged 1 commit into from
Jun 19, 2024
+5 −35

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jun 18, 2024

daipom
daipom approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.
We need to fix CGroupV1 tests...

@kenhys
Copy link
Contributor Author

kenhys commented Jun 18, 2024

We need to fix CGroupV1 tests...

It seems that we need to give lxd up.

@kenhys
Copy link
Contributor Author

kenhys commented Jun 18, 2024

Let's switch to incus in another PR.

@daipom
Copy link
Contributor

daipom commented Jun 18, 2024

I don't understand this cause...
In my local Ubuntu 20.04, I can install CGroup v1 images.
Has the specification (related to CGroup) of the runner Ubuntu 20.04 been changed?

@kenhys
Copy link
Contributor Author

kenhys commented Jun 18, 2024

As previously same workflow worked, so I guess that GitHub runner configuration such as remote server access or something was changed or blocked, but few clue to identify it. (I don't have enough experience) 😕

@daipom
Copy link
Contributor

daipom commented Jun 19, 2024 •
edited
Loading

As previously same workflow worked, so I guess that GitHub runner configuration such as remote server access or something was changed or blocked, but few clue to identify it. (I don't have enough experience) 😕

Thanks. I see.
Anyway, it looks like we should try Incus on another PR.

@kenhys
Copy link
Contributor Author

kenhys commented Jun 19, 2024

rebased with master. expected CI will pass.

@kenhys kenhys added this to the 5.0.4 (T.B.D.) milestone Jun 19, 2024
@daipom
Copy link
Contributor

daipom commented Jun 19, 2024

msi: update bundled ruby to 3.2.4

Isn't this for the entire Ruby version in the package?

@kenhys kenhys changed the title msi: update bundled ruby to 3.2.4 msi: update target ruby version to 3.2.4 Jun 19, 2024
@kenhys kenhys changed the title msi: update target ruby version to 3.2.4 update target ruby version to 3.2.4 Jun 19, 2024
daipom
daipom approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@kenhys kenhys merged commit fc2947f into fluent:master Jun 19, 2024
61 checks passed
@kenhys kenhys deleted the ruby324 branch June 19, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashie ashie ashie left review comments

@daipom daipom daipom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@kenhys @daipom @ashie