-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: extract test file as element of matrix #636
Conversation
I have one concern. I don't run tests on my local these days. Come to think of it, I was thinking that I could use I thought that this could be used as follows: for test_filename in ${test_filenames[@]}; do
echo -e "::group::Run test: $test_filename\n"
...
echo "::endgroup::"
done |
Sorry, I don't think we need to worry too much about this point. |
Thanks,
It may be. so it takes into account by |
I didn't know such a feature, Thanks! |
005e3b8
to
1ec1e3e
Compare
6e94afb
to
c4daf65
Compare
re-run stalled jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, basically!
I just commented on a little thing.
Before: test.sh execute multiple test files. This behavior make it hard to distinct failure test cases. After: * Use test.sh as launch script. It doesn't execute multiple test files. This change was introduced to make it easy to distinct each test cases on error. * Use grouping log lines feature See https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines NOTE: If you want to test manually on VM, execute each test script separately on it. Signed-off-by: Kentaro Hayashi <[email protected]>
Before:
test.sh execute multiple test files.
This behavior make it hard to distinct failure test cases.
After:
Use test.sh as launch script. It doesn't execute multiple test files.
This change was introduced to make it easy to distinct each test
cases on error.