Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msi: remove unnecessary path delimiter #607

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Dec 13, 2023

The last character of %~dp0 is \, so we don't need add it.
(Though it appears it does not cause any problems.)

The last character of `%~dp0` is `\`, so we don't need add it.
(Though it appears it does not cause any problems.)

Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Kentaro Hayashi <[email protected]>
@daipom daipom marked this pull request as ready for review December 13, 2023 04:38
@daipom
Copy link
Contributor Author

daipom commented Dec 13, 2023

Note: #606 (comment)

@daipom daipom requested a review from kenhys December 13, 2023 04:38
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks.

@kenhys kenhys merged commit c75754e into fluent:master Dec 13, 2023
12 checks passed
@daipom daipom deleted the msi-remove-unnecessary-path-delimiter branch December 13, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants