Fix system user/group name in logrotate config #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. We will confirm this. Could you add DCO to the commit? |
rahulbpatil
force-pushed
the
fix-logrotate-config
branch
from
a9b242b to
2ae203a
Compare
|
I have confirmed I can't logrotate by I think we need some additional fixes. |
Signed-off-by: Rahul Patil <[email protected]>
rahulbpatil
force-pushed
the
fix-logrotate-config
branch
from
2ae203a to
b5503d1
Compare
|
It seems that some testing CI fails, but it should be fixed in another PR. |
TODO: We need to fix this problem. |
kenhys
added a commit
to kenhys/fluent-package-builder
that referenced
this pull request
Oct 16, 2023
This reverts commit bf66110. Note that fluent-package/templates/etc/logrotate.d/fluentd is used for not only deb, but also rpm.
kenhys
added a commit
to kenhys/fluent-package-builder
that referenced
this pull request
Oct 16, 2023
This is follow-up of fluent#592 to fix problem correctly. fluent-package/tempaltes/etc/logrotate.d/fluentd is used for deb and rpm, so it should support both of different system user/group respectively. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
to kenhys/fluent-package-builder
that referenced
this pull request
Oct 16, 2023
This reverts commit bf66110. Note that fluent-package/templates/etc/logrotate.d/fluentd is used for not only deb, but also rpm. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
to kenhys/fluent-package-builder
that referenced
this pull request
Oct 16, 2023
This is follow-up of fluent#592 to fix problem correctly. fluent-package/tempaltes/etc/logrotate.d/fluentd is used for deb and rpm, so it should support both of different system user/group respectively. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
to kenhys/fluent-package-builder
that referenced
this pull request
Oct 16, 2023
This is follow-up of fluent#592 to fix problem correctly. fluent-package/tempaltes/etc/logrotate.d/fluentd is used for deb and rpm, so it should support both of different system user/group respectively. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
to kenhys/fluent-package-builder
that referenced
this pull request
Oct 20, 2023
This is follow-up of fluent#592 to fix problem correctly. fluent-package/tempaltes/etc/logrotate.d/fluentd is used for deb and rpm, so it should support both of different system user/group respectively. Signed-off-by: Kentaro Hayashi <[email protected]>
daipom
pushed a commit
that referenced
this pull request
Nov 16, 2023
This is follow-up of #592 to fix problem correctly. fluent-package/tempaltes/etc/logrotate.d/fluentd is used for deb and rpm, so it should support both of different system user/group respectively. --------- Signed-off-by: Kentaro Hayashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix system user/group name in logrotate config
I had installed
fluent-package-5.0.1-1on ubuntu 22.04With fluent-package v5 user/group name is changed to
_fluentdHowever user/group name in logrotate config is
fluentd, which causes following failureI guess this change was introduced in - #449