-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: check downgrade to v4 #591
Conversation
Thanks! fluent-package-builder/fluent-package/yum/systemd-test/test.sh Lines 21 to 25 in b4b7017
fluent-package-builder/fluent-package/apt/systemd-test/test.sh Lines 26 to 30 in b4b7017
|
f6f338f
to
3ac0a90
Compare
checking failure on local vm. |
Technically package downgrade will work but, not same as before. |
7497943
to
242ec1e
Compare
0f89c50
to
3b7eeb2
Compare
d71a2bb
to
dee317c
Compare
Thanks! I'm concerned about the following points.
|
In my local env Rocky Linux 8, I don't need to manually remove the td-agent.service alias. I'm testing daipom@3471b31 on my fork: |
Let me sort out the necessary steps for downgrading while looking at these results. |
In my conclusion, these are required only for deb. |
To downgrade correctly you must: * Remove fluent-package in beforehand. * Manually migrate buffer or logs * Re-install td-agent v4. NOTE: on debian/ubuntu, need to disable td-agent.service alias beforehand because: * It conflict with v4 td-agent.service * If you didn't disable it, it causes broken symlink from td-agent.service to /lib/systemd/system/fluentd.service. Signed-off-by: Kentaro Hayashi <[email protected]>
6157e9a
to
9ed7c9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM!
github: check downgrade to v4