Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: check downgrade to v4 #591

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Sep 28, 2023

github: check downgrade to v4

To downgrade correctly you must:

* Remove fluent-package in beforehand.
* Manually migrate buffer or logs
* Re-install td-agent v4.

NOTE: on debian/ubuntu, need to disable td-agent.service alias
beforehand because:
  * It conflict with v4 td-agent.service
  * If you didn't disable it, it causes broken symlink from td-agent.service to /lib/systemd/system/fluentd.service.

@kenhys kenhys added this to the 5.0.2 (T.B.D) milestone Sep 28, 2023
@daipom
Copy link
Contributor

daipom commented Sep 28, 2023

Thanks!
We need to add this new test here to run it in CI.

test_filenames=(
update-from-v4.sh
update-to-next-version.sh
update-to-next-version-with-backward-compat-for-v4.sh
)

# As no bookworm package for v4, so execute upgrade test for other code name.
test_filenames+=(
update-from-v4.sh
update-to-next-version-with-backward-compat-for-v4.sh
)

@kenhys kenhys force-pushed the check-downgrade branch 2 times, most recently from f6f338f to 3ac0a90 Compare September 29, 2023 01:23
@kenhys
Copy link
Contributor Author

kenhys commented Sep 29, 2023

checking failure on local vm.

@kenhys
Copy link
Contributor Author

kenhys commented Sep 29, 2023

Technically package downgrade will work but, not same as before.
Thus, uninstall v5 && re install v4 is the recommended action to do now.

@kenhys kenhys force-pushed the check-downgrade branch 5 times, most recently from 7497943 to 242ec1e Compare September 29, 2023 08:10
@kenhys kenhys force-pushed the check-downgrade branch 2 times, most recently from 0f89c50 to 3b7eeb2 Compare November 28, 2023 04:40
@kenhys kenhys force-pushed the check-downgrade branch 8 times, most recently from d71a2bb to dee317c Compare December 11, 2023 06:27
@kenhys kenhys marked this pull request as ready for review December 11, 2023 07:14
@kenhys kenhys requested a review from daipom December 11, 2023 07:14
@daipom
Copy link
Contributor

daipom commented Dec 11, 2023

Thanks! I'm concerned about the following points.
I didn't think this step was necessary.
I'm checking the behavior.

* Disable td-agent.service alias beforehand.
  
  * It conflict with v4 td-agent.service
  * If you didn't disable it, it causes broken symlink from td-agent.service to /lib/systemd/system/fluentd.service.

@kenhys kenhys modified the milestones: 5.0.2, 5.0.3 (T.B.D.) Dec 11, 2023
@daipom
Copy link
Contributor

daipom commented Dec 11, 2023

In my local env Rocky Linux 8, I don't need to manually remove the td-agent.service alias.
It is automatically removed when uninstalling fluent-package.

I'm testing daipom@3471b31 on my fork:

@daipom
Copy link
Contributor

daipom commented Dec 11, 2023

In my local env Rocky Linux 8, I don't need to manually remove the td-agent.service alias. It is automatically removed when uninstalling fluent-package.

I'm testing daipom@3471b31 on my fork:

* rpm: https://github.com/daipom/fluent-package-builder/actions/runs/7164750480

* apt: https://github.com/daipom/fluent-package-builder/actions/runs/7164750483

Let me sort out the necessary steps for downgrading while looking at these results.

@daipom
Copy link
Contributor

daipom commented Dec 12, 2023

To downgrade correctly you must:

* Disable td-agent.service alias beforehand.
  
  * It conflict with v4 td-agent.service
  * If you didn't disable it, it causes broken symlink from td-agent.service to /lib/systemd/system/fluentd.service.

* Purge v5 apt-line in fluent-lts-apt-source or fluent-apt-source.

In my conclusion, these are required only for deb.
For rpm, we don't need these steps because symlinks are automatically removed when uninstalling.

To downgrade correctly you must:

* Remove fluent-package in beforehand.
* Manually migrate buffer or logs
* Re-install td-agent v4.

NOTE: on debian/ubuntu, need to disable td-agent.service alias
beforehand because:
  * It conflict with v4 td-agent.service
  * If you didn't disable it, it causes broken symlink from td-agent.service to /lib/systemd/system/fluentd.service.

Signed-off-by: Kentaro Hayashi <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@daipom daipom merged commit a33b1a6 into fluent:master Dec 13, 2023
21 of 22 checks passed
@kenhys kenhys deleted the check-downgrade branch December 13, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants