-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oracle log analytics plugin #946
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: adiforluls <[email protected]>
e9bf651
to
3a9b080
Compare
cc: @benjaminhuo , this should go in after you uptake FluentBit v2.1.10 |
@@ -100,7 +100,8 @@ type OutputSpec struct { | |||
S3 *output.S3 `json:"s3,omitempty"` | |||
// Gelf defines GELF Output configuration. | |||
Gelf *output.Gelf `json:"gelf,omitempty"` | |||
|
|||
// OracleLogAnalytics defines OracleLogAnalytics Output configuration | |||
OracleLogAnalytics *output.OracleLogAnalytics `json:"oracleLogAnalytics,omitempty"` | |||
// CustomPlugin defines Custom Output configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a link to the official plugin documentation? Is this the plugin?
https://docs.fluentbit.io/manual/pipeline/outputs/azure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a link to the official plugin documentation? Is this the plugin?
@adiforluls I can not find this OracleLogAnalytics output plugin in outputs, is this an official plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's a new plugin that I wrote and is part if v2.1.10, but looks like I made a small mistake in my fluentbit docs contribution due to which the docs aren't visible. I'm fixing it and will post here after the docs are visible.
@adiforluls Thanks for this. Currently, fluent operator is still using FluentBit 2.1.9, it'll be great if you can upgrade FluentBit to 2.1.10 in another PR by global searching and replacing |
@adiforluls Should I merge this for now? |
@benjaminhuo Actually was thinking if instead of |
We are planning to release |
Marking it as draft for now, currently doing more work on fluent-bit side of things for this plugin that will reflect in this PR later. |
@adiforluls Let us know if this is ready to be reviewed :) |
This is ready for review |
What this PR does / why we need it:
Oracle Log Analytics plugin support via Output and ClusterOutput CR in FluentBit. This is a new plugin that I added in FluentBit and was released as part of v2.1.10.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: