Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oracle log analytics plugin #946

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adiforluls
Copy link
Member

What this PR does / why we need it:

Oracle Log Analytics plugin support via Output and ClusterOutput CR in FluentBit. This is a new plugin that I added in FluentBit and was released as part of v2.1.10.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@adiforluls adiforluls force-pushed the aditya/oracle-log-analytics branch from e9bf651 to 3a9b080 Compare October 4, 2023 09:30
@adiforluls
Copy link
Member Author

adiforluls commented Oct 4, 2023

cc: @benjaminhuo , this should go in after you uptake FluentBit v2.1.10

@@ -100,7 +100,8 @@ type OutputSpec struct {
S3 *output.S3 `json:"s3,omitempty"`
// Gelf defines GELF Output configuration.
Gelf *output.Gelf `json:"gelf,omitempty"`

// OracleLogAnalytics defines OracleLogAnalytics Output configuration
OracleLogAnalytics *output.OracleLogAnalytics `json:"oracleLogAnalytics,omitempty"`
// CustomPlugin defines Custom Output configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a link to the official plugin documentation? Is this the plugin?
https://docs.fluentbit.io/manual/pipeline/outputs/azure
1696599488220

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a link to the official plugin documentation? Is this the plugin?

@adiforluls I can not find this OracleLogAnalytics output plugin in outputs, is this an official plugin?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's a new plugin that I wrote and is part if v2.1.10, but looks like I made a small mistake in my fluentbit docs contribution due to which the docs aren't visible. I'm fixing it and will post here after the docs are visible.

@benjaminhuo
Copy link
Member

benjaminhuo commented Oct 7, 2023

cc: @benjaminhuo , this should go in after you uptake FluentBit v2.1.10

@adiforluls Thanks for this. Currently, fluent operator is still using FluentBit 2.1.9, it'll be great if you can upgrade FluentBit to 2.1.10 in another PR by global searching and replacing 2.1.9 with 2.1.10 in places like https://github.com/fluent/fluent-operator/blob/master/cmd/fluent-watcher/fluentbit/Dockerfile#L9

@benjaminhuo
Copy link
Member

@adiforluls Should I merge this for now?

@adiforluls
Copy link
Member Author

adiforluls commented Oct 19, 2023

@benjaminhuo Actually was thinking if instead of ConfigFileLocation used in auth, where you'd need to supply the location of oci config file inside fluentbit pod, the config file could be supplied as a secret and fluent-operator can automount the file to a particular location. I'll get to it next week.
FYI the docs for this plugin were published https://docs.fluentbit.io/manual/pipeline/outputs/oci-logging-analytics

@wenchajun
Copy link
Member

We are planning to release fluent-operator in the near future and would like to merge this pr, do you have any plans to update it in the near future?

@adiforluls adiforluls marked this pull request as draft November 22, 2023 16:19
@adiforluls
Copy link
Member Author

Marking it as draft for now, currently doing more work on fluent-bit side of things for this plugin that will reflect in this PR later.

@benjaminhuo
Copy link
Member

@adiforluls Let us know if this is ready to be reviewed :)

@adiforluls adiforluls marked this pull request as ready for review April 22, 2024 14:15
@adiforluls
Copy link
Member Author

This is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants