Changed the kafka_types.go file and introduced a mapvalue struct. #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In kvs.go, introduced an InsertValueMap function and a SecretProvider interface. Signed-off-by: TheJadeLion2004 <[email protected]>
|
I've created a pull request in order to check the base logic, and to get help in verifying errors. This is NOT a working PR. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kvs.go, introduced an InsertValueMap function and a SecretProvider interface.
What this PR does / why we need it:
The PR attempts to change the type of the Kafka struct from a dictionary of strings to a dictionary of variant type, where the variant contains either a string or a *plugins.Secret. Needed to also change the InsertStringValueMap function and replace it by an insert MapValueMap function which does whatever the original function does, but now, tries to add elements to the map of the variant type.
An interface was used to avoid circular dependency, however there is some deepcopy error that is being generated.
Which issue(s) this PR fixes:
Fixes # #1152
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: