-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parameterized the tagging of tail plugin #1237
base: master
Are you sure you want to change the base?
parameterized the tagging of tail plugin #1237
Conversation
@harshvora10101 Thanks for the PR. You'll need to sign your commit by: git commit -s --amend
git push -f |
@@ -10,7 +10,7 @@ metadata: | |||
fluentbit.fluent.io/component: logging | |||
spec: | |||
tail: | |||
tag: kube.* | |||
tag: {{ .Values.fluentbit.input.tail.tag }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not enough to modify tag for tail input only.
For example, it's used by other plugins like filter and output:
https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-clusterfilter-kubernetes.yaml#L12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it.
I will update this PR with the wider plugin lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and I will also sign the commits.
Signed-off-by: Harsh Vora <[email protected]>
4b67ff3
to
34a7019
Compare
Signed-off-by: Harsh Vora <[email protected]>
09168bb
to
6231919
Compare
@benjaminhuo Added the required changes. |
There are output plugins affected too https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-output-opensearch.yaml#L12 Fluent Operator is used to deploy FluentBit to collect k8s logs, so kube.* is ok. cc @wanjunlei |
With this change, we are not changing the tag (Just making the code generalized). So I doubt that output plugins will be affected. There are use cases where we need multiple tail plugins for different applications with different tags. So a hardcoded tag is hard to change. |
To be precise |
https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-output-elasticsearch.yaml#L12 Shouldn't this situation be dealt with as well? |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes 1 :
Parameterising the tag for tail plugin. Overriding this value will help changing the tags according to the requirements.