Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterized the tagging of tail plugin #1237

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harshvora10101
Copy link

@harshvora10101 harshvora10101 commented Jul 11, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes 1 :
Parameterising the tag for tail plugin. Overriding this value will help changing the tags according to the requirements.

@benjaminhuo
Copy link
Member

@harshvora10101 Thanks for the PR. You'll need to sign your commit by:

git commit -s --amend
git push -f

@@ -10,7 +10,7 @@ metadata:
fluentbit.fluent.io/component: logging
spec:
tail:
tag: kube.*
tag: {{ .Values.fluentbit.input.tail.tag }}
Copy link
Member

@benjaminhuo benjaminhuo Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.
I will update this PR with the wider plugin lists.

Copy link
Author

@harshvora10101 harshvora10101 Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I will also sign the commits.

@harshvora10101 harshvora10101 force-pushed the parameterization-of-tags branch from 4b67ff3 to 34a7019 Compare July 12, 2024 09:54
Signed-off-by: Harsh Vora <[email protected]>
@harshvora10101 harshvora10101 force-pushed the parameterization-of-tags branch from 09168bb to 6231919 Compare July 12, 2024 10:04
@harshvora10101
Copy link
Author

harshvora10101 commented Jul 12, 2024

@benjaminhuo Added the required changes.

@benjaminhuo
Copy link
Member

benjaminhuo commented Jul 12, 2024

There are output plugins affected too https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-output-opensearch.yaml#L12

Fluent Operator is used to deploy FluentBit to collect k8s logs, so kube.* is ok.
I wonder what's the reason for changing this tag to others.

cc @wanjunlei

@harshvora10101
Copy link
Author

harshvora10101 commented Jul 12, 2024

@benjaminhuo

With this change, we are not changing the tag (Just making the code generalized). So I doubt that output plugins will be affected.

There are use cases where we need multiple tail plugins for different applications with different tags. So a hardcoded tag is hard to change.

@harshvora10101
Copy link
Author

harshvora10101 commented Jul 12, 2024

To be precise
There are multiple tail plugins used for kubernetes with xyz.kube.* and abc.kube.* etc.

@wenchajun
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants