Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite tag nil pointer reference #1232

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

cw-Guo
Copy link
Collaborator

@cw-Guo cw-Guo commented Jul 4, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1231

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@benjaminhuo
Copy link
Member

@cw-Guo Thanks for fixing this.
The controller-gen has been upgraded in https://github.com/fluent/fluent-operator/pull/1220/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R151

You may need to update the version in your env and build again

@cw-Guo
Copy link
Collaborator Author

cw-Guo commented Jul 5, 2024

looks like I do have the updated version in my code https://github.com/cw-Guo/fluent-operator/blob/fix/rewrite-tag/Makefile#L150-L151

@benjaminhuo What do i need to do specifically to upgrade my env?

@benjaminhuo
Copy link
Member

looks like I do have the updated version in my code https://github.com/cw-Guo/fluent-operator/blob/fix/rewrite-tag/Makefile#L150-L151

@benjaminhuo What do i need to do specifically to upgrade my env?

@cw-Guo You may need to make manifests generate

@cw-Guo
Copy link
Collaborator Author

cw-Guo commented Jul 5, 2024

looks like I do have the updated version in my code https://github.com/cw-Guo/fluent-operator/blob/fix/rewrite-tag/Makefile#L150-L151
@benjaminhuo What do i need to do specifically to upgrade my env?

@cw-Guo You may need to make manifests generate

@benjaminhuo Yes, I have already do that. But It looks like the go.mod keeps fetching k8s.io/code-generator v0.26.1

@cw-Guo cw-Guo force-pushed the fix/rewrite-tag branch from c7644c8 to c5e306f Compare July 5, 2024 04:31
@cw-Guo
Copy link
Collaborator Author

cw-Guo commented Jul 5, 2024

@benjaminhuo looks like my go version was 1.21. Fixed now.

@benjaminhuo benjaminhuo merged commit 8e9bae2 into fluent:master Jul 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Fluent Operator pod crashes while processing FluentBitConfig namespaced resource
2 participants