Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: in_dummy: try and wait for the first record before doing checks. #8276

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Dec 12, 2023

Summary

Add a busy wait loop for in_dummy checks that wait around 5 seconds or for the first record before tests check record count. This should make tests less flaky when running on hosted multi-tenant environments.

I ran the test several times while running sysbench, similar to my previous log test fix.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@edsiper
Copy link
Member

edsiper commented Dec 12, 2023

commit needs to be "tests: runtime: in_symple_system:.." , fixed by squashing the PR

@edsiper edsiper merged commit e3dcc14 into master Dec 12, 2023
45 checks passed
@edsiper edsiper deleted the pwhelan-test-dummy-fix branch December 12, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants