-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Remove duplicated line FLB_IN_EVENT_TEST #8268
Merged
edsiper
merged 1 commit into
fluent:master
from
fbarbeira:removed-duplicated-line-event-test
Jan 14, 2024
Merged
build: Remove duplicated line FLB_IN_EVENT_TEST #8268
edsiper
merged 1 commit into
fluent:master
from
fbarbeira:removed-duplicated-line-event-test
Jan 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarbeira
requested review from
fujimotos,
niedbalski,
patrick-stephens and
celalettin1286
as code owners
December 11, 2023 11:26
nokute78
requested changes
Dec 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix DCO error ?
https://github.com/fluent/fluent-bit/pull/8268/checks?check_run_id=19511392439
FLB_IN_EVENT_TEST is specified twice. I guess the latter prevails. Signed-off-by: Félix Barbeira <[email protected]>
nokute78
approved these changes
Jan 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM.
patrick-stephens
approved these changes
Jan 8, 2024
thank you |
shaerpour
pushed a commit
to shaerpour/fluent-bit
that referenced
this pull request
Jan 16, 2024
FLB_IN_EVENT_TEST is specified twice. I guess the latter prevails. Signed-off-by: Félix Barbeira <[email protected]>
shaerpour
pushed a commit
to shaerpour/fluent-bit
that referenced
this pull request
Jan 16, 2024
FLB_IN_EVENT_TEST is specified twice. I guess the latter prevails. Signed-off-by: Félix Barbeira <[email protected]> Signed-off-by: ahspw <[email protected]>
pwhelan
pushed a commit
that referenced
this pull request
Jan 16, 2024
FLB_IN_EVENT_TEST is specified twice. I guess the latter prevails. Signed-off-by: Félix Barbeira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLB_IN_EVENT_TEST is specified twice. I guess the latter prevails.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.