build: Remove duplicated line FLB_IN_EVENT_TEST #8250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FLB_IN_EVENT_TEST is specified twice. I guess the latter prevails. Signed-off-by: Félix Barbeira <[email protected]>
fbarbeira
requested review from
fujimotos,
niedbalski,
patrick-stephens and
celalettin1286
as code owners
nokute78
requested changes
Dec 10, 2023
There was a problem hiding this comment.
Thank you for catching this.
Could you modify commit message like
build: Remove duplicated line FLB_IN_EVENT_TEST ?
https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#commit-changes
fbarbeira
changed the title
|
Can you update the merge commit message or squash/rebase it? |
|
I'll made a new PR with the right commits, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLB_IN_EVENT_TEST is specified twice. I guess the latter prevails.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.