Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_prometheus_exporter: Add expire time to metrics in prometheus_exporter #8075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdjjiiik
Copy link

@bdjjiiik bdjjiiik commented Oct 21, 2023


Add expire time tometrics in prometheus_exporter.
These improvements are related to the fact that when some data sources are hit, the last value of the metric remains on the graphs, which worsens the understanding of the situation

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
[SERVICE]
    flush       1
    log_level   info

[INPUT]
    Name          dummy
    Dummy         {"log": "dummy"}
    tag           dummy

[INPUT]
    Name              tail
    Path              fluent.log
    tag               logs

[FILTER]
    name               log_to_metrics
    tag                metrics
    match              logs
    metric_mode        gauge
    metric_name        message
    metric_description last message
    value_field        log

[FILTER]
    name               log_to_metrics
    tag                metric
    match              dummy
    metric_mode        gauge
    metric_name        dummy-message
    metric_description last dummy-message
    value_field        log

[OUTPUT]
    name            prometheus_exporter
    match           metrics
    host            0.0.0.0
    port            2021
    ttl             10s
  • [N/A] Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@bdjjiiik bdjjiiik changed the title Add expire time to metrics in prometheus_exporter out_prometheus_exporter: Add expire time to metrics in prometheus_exporter Oct 21, 2023
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 22, 2024
@github-actions github-actions bot removed the Stale label Aug 16, 2024
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant