Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: backport fixes that landed in master v2.2 recently #8054

Closed
wants to merge 4 commits into from

Conversation

edsiper
Copy link
Member

@edsiper edsiper commented Oct 17, 2023


Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

cosmo0920 and others added 4 commits October 17, 2023 08:23
After supporting fleet management on Windows,
Ctrl-C events won't be caught up.
This commit re-enables for the behavior.
Windows' ctrl event handlers stolen signals which are overlapped ones.
So, we need to handle Ctrl-C events on the newly added event handler for Windows.

In Windows, SIGINT and SIGBREAK are valid ctrl events on their terminal.
This is why we only need to handle CTRL_C_EVENT and CTRL_BREAK_EVENT events on console handler.

Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
@edsiper edsiper temporarily deployed to pr October 17, 2023 14:39 — with GitHub Actions Inactive
@edsiper edsiper temporarily deployed to pr October 17, 2023 14:39 — with GitHub Actions Inactive
@edsiper edsiper temporarily deployed to pr October 17, 2023 14:39 — with GitHub Actions Inactive
@edsiper edsiper temporarily deployed to pr October 17, 2023 14:40 — with GitHub Actions Inactive
@edsiper edsiper temporarily deployed to pr October 17, 2023 14:40 — with GitHub Actions Inactive
@edsiper edsiper temporarily deployed to pr October 17, 2023 14:40 — with GitHub Actions Inactive
@edsiper edsiper temporarily deployed to pr October 17, 2023 15:25 — with GitHub Actions Inactive
@edsiper edsiper temporarily deployed to pr October 17, 2023 15:27 — with GitHub Actions Inactive
@edsiper edsiper closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants