Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_oracle_log_analytics: Add two more modes of authentication #7957

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

adiforluls
Copy link
Member

This PR adds support for https://blogs.oracle.com/cloud-infrastructure/post/oke-workload-identity-greater-control-access and https://docs.oracle.com/en-us/iaas/Content/Identity/Tasks/callingservicesfrominstances.htm


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: adiforluls <[email protected]>
@adiforluls
Copy link
Member Author

@patrick-stephens in the pipelines that failed, I see

#11 129.8 ../library/libflb-plugin-out_oracle_log_analytics.a(oci_client.c.o): In function `get_tenancy_id_from_certificate':
#11 129.8 /src/plugins/out_oracle_log_analytics/oci_client.c:276: undefined reference to `ASN1_STRING_get0_data'
#11 129.8 ../library/libflb-plugin-out_oracle_log_analytics.a(oci_client.c.o): In function `session_key_supplier':
#11 129.8 /src/plugins/out_oracle_log_analytics/oci_client.c:382: undefined reference to `EVP_PKEY_CTX_set1_rsa_keygen_pubexp'
#11 129.8 /src/plugins/out_oracle_log_analytics/oci_client.c:389: undefined reference to `PEM_write_bio_PrivateKey_traditional'

I suspect maybe some openssl related build option needs to be passed, these funcs are from that library. Would you know how I can tweak these tests?

Signed-off-by: adiforluls <[email protected]>
@patrick-stephens
Copy link
Contributor

I'm afraid I can't help much there, maybe check other examples in the code?

Also, I assume this will need a docs update too? Please can you link the PR.

Signed-off-by: adiforluls <[email protected]>
Signed-off-by: adiforluls <[email protected]>
Signed-off-by: adiforluls <[email protected]>
Signed-off-by: adiforluls <[email protected]>
@adiforluls
Copy link
Member Author

adiforluls commented Nov 22, 2023

@patrick-stephens @edsiper is fluent-bit tied to a specific version of openssl? In ubuntu and centos PR checks, I'm seeing this

/home/runner/work/fluent-bit/fluent-bit/src/oracle/flb_oracle_client.c:951: undefined reference to `EVP_PKEY_CTX_set1_rsa_keygen_pubexp'

https://www.openssl.org/docs/manmaster/man3/EVP_PKEY_CTX_set1_rsa_keygen_pubexp.html
I suspect openssl version in the pipelines isn't 3.x?

@adiforluls
Copy link
Member Author

@edsiper @patrick-stephens I think the problem with the pipeline failure is that the tests are using Ubuntu 20.04, which has latest available openssl version 1.1.1 https://launchpad.net/ubuntu/focal/+source/openssl. The API that I've used which is giving me the trouble is part of Openssl 3.x, it's predecessors have been marked as deprecated by openssl so hesitating to switch to those.

Should I update the test (Ubuntu version (22.04) which has openssl 3.x available)? Let me know how to proceed forward. This is an important contribution to connect to Oracle Cloud Infrastructure endpoints.

Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Feb 29, 2024
@github-actions github-actions bot removed the Stale label Aug 16, 2024
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants