go: plugin_proxy: Handle FLBPluginInit(cb_init) error correctly and p…

…lug a SEGV case Signed-off-by: Hiroshi Hatake <[email protected]>
fluent · Dec 12, 2023 · 2a8cfcb · 2a8cfcb
1 parent 469652f
commit 2a8cfcb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/flb_plugin_proxy.c b/src/flb_plugin_proxy.c
@@ -525,6 +525,12 @@ int flb_proxy_output_cb_init(struct flb_output_instance *o_ins,
                   pc->proxy->def->proxy);
     }
 
+    if (ret == -1) {
+        flb_error("[output] could not initialize '%s' plugin",
+                  o_ins->p->name);
+        return -1;
+    }
+
     /* Multi-threading enabled if configured */
     ret = flb_output_enable_multi_threading(o_ins, config);
     if (ret == -1) {

diff --git a/src/proxy/go/go.c b/src/proxy/go/go.c
@@ -110,7 +110,6 @@ int proxy_go_output_init(struct flb_plugin_proxy *proxy)
     if (ret <= 0) {
         flb_error("[go proxy]: plugin '%s' failed to initialize",
                   plugin->name);
-        flb_free(plugin);
         return -1;
     }